fix(*) incopatibility with blink-cmp as well as nvim-cmp #354

[Ajaymamtora]

Fixes #354

[andymass]

Thanks for contributing. Is this ready or WIP?

[Slotos]

This solution looks categorically wrong. vim-matchup has nothing to do with nvim-cmp nor blink.cmp. The problem of "pretend pop-up menu is open" is also not specific to those specific completion plugins.

A "good neighbor" approach here would be for vim-matchup to allow setting a ppumvisible() handler, that users can use to deal with whatever tooling they are employing at the moment. A few examples for specific plugins can be provided in the wiki.

vim-matchup should not fix design choices of other plugins, however reasonable those choices are.

[Ajaymamtora]

This solution looks categorically wrong. vim-matchup has nothing to do with nvim-cmp nor blink.cmp. The problem of "pretend pop-up menu is open" is also not specific to those specific completion plugins.

A "good neighbor" approach here would be for vim-matchup to allow setting a ppumvisible() handler, that users can use to deal with whatever tooling they are employing at the moment. A few examples for specific plugins can be provided in the wiki.

vim-matchup should not fix design choices of other plugins, however reasonable those choices are.

There was already something in the codebase that handled nvim-cmp - I extended it to support blink.cmp.

[Ajaymamtora]

Thanks for contributing. Is this ready or WIP?

This is kind of a WIP but I think I've got a workaround without this PR:

    local cmp_list = require("blink.cmp.completion.list")

    -- Handler for show event
    cmp_list.show_emitter:on(function()
      vim.g.matchup_enabled = false
    end)

    -- Handler for hide event
    cmp_list.hide_emitter:on(function()
      vim.g.matchup_enabled = false
    end)

So going to test it a bit more and might end up abandoning