Skip to content

Wrong generated brace after Enter #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
angelozerr opened this issue Aug 23, 2016 · 3 comments
Closed

Wrong generated brace after Enter #72

angelozerr opened this issue Aug 23, 2016 · 3 comments

Comments

@angelozerr
Copy link
Owner

If we have this contant:

class A {// here we typer Enter
  f() {
  }
}

Enter generates a wrong brace:

class A {

} // here wrong brace is generated
  f() {
  }
}

The JSDT editor does like this.

@angelozerr
Copy link
Owner Author

It's a JSDT issue. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=500465

@sdargutev
Copy link

This seems to be a conflict between the Preference "Window->Preferences->JavaScript->Editor->Typing--> 'Automatically close {Braces}'", and maybe own implementation of inserting matching brace?

If you remove the checkmark from the 'Automatically close {Braces}' preference, the editor does not insert unneeded brace anymore, and it all works fine.

@angelozerr
Copy link
Owner Author

@sdargutev I'm using JSDT code to manage insert of bracket. There is the same problem with JSDT JavaScript Editor. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=500465

@angelozerr angelozerr added this to the 1.2.0 milestone Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants