Skip to content

Format on Save #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2017
Merged

Format on Save #145

merged 2 commits into from
Feb 13, 2017

Conversation

lorenzodallavecchia
Copy link
Contributor

Closes #81.

The new method makes it easy to set inter-dependent control states
(typically conditional enabling).
@lorenzodallavecchia lorenzodallavecchia changed the title Pr/format on save Format on Save Feb 13, 2017
@angelozerr angelozerr added this to the 1.2.0 milestone Feb 13, 2017
@angelozerr angelozerr merged commit e196ecf into angelozerr:master Feb 13, 2017
@angelozerr
Copy link
Owner

Great PR @lorenzodallavecchia!

Please note thisat tsserver seems providing capability to format "on key". I think we should investigate too this feature (I think that VSCode uses it).

@lorenzodallavecchia
Copy link
Contributor Author

Please note thisat tsserver seems providing capability to format "on key"

I had spotted that one in protocol.d.ts, but did not know whether you were already using it or not (now I assume not!).

I may look into that later, especially since I want to track down a strange bug that causes nothing to happen when presseing Enter from within two braces: really annoying.

@angelozerr
Copy link
Owner

angelozerr commented Feb 13, 2017

I had spotted that one in protocol.d.ts, but did not know whether you were already using it or not (now I assume not!).

@lorenzodallavecchia see #146

@angelozerr
Copy link
Owner

I may look into that later, especially since I want to track down a strange bug that causes nothing to happen when presseing Enter from within two braces: really annoying.

Could you create an issue for that please.

@angelozerr
Copy link
Owner

may look into that later, especially since I want to track down a strange bug that causes nothing to happen when presseing Enter from within two braces: really annoying.

Is it #72 ?

@lorenzodallavecchia
Copy link
Contributor Author

Could you create an issue for that please.
Is it #72 ?

No, it is not #72.
I will surely create an issue: I just need to find a consistent way to reproduce it.

@lorenzodallavecchia lorenzodallavecchia deleted the pr/format-on-save branch February 14, 2017 07:42
@lorenzodallavecchia
Copy link
Contributor Author

Ok I found out what was causing that other problem. I reported and closed it (#150) so it remains for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants