Contribute TypeScript repositories via an extension point

[lorenzodallavecchia]

The embedded TypeScript and TSLint installations are retrieved directly from the ts.repository bundle (from root and archives subdir), making the mechanism completely hard-coded.

This makes it difficult or impossible to

• deploy typescript.java without the embedded modules,
• contribute modules in other way, for example because one needs a different version or wants to share with other Eclipse plugins.

This change introduces an extension point, similar to the one for Node.js installations. An extension can contribute one or more repositories, each containing TypeScript and TSLint. The default repository is choosen to be the one with the highest TypeScript version.

[angelozerr]

@lorenzodallavecchia have you seen that you can choose your TypeScript version with project preferences?

[lorenzodallavecchia]

Yes I know about that possibility. In this case, however, I need to affect the available Embedded TypeScript options, not just change the default.

As you may have guessed, I am integrating typescript.java into a larger Eclipse-based product along with other plugins. Since I am already bundling TypeScript for my own needs, I did not like to have to include it twice (one inside ts.repository and one inside my own plugin), nor I wanted to access ts.repository directory from the bundle registry.
With an extension point I can remove ts.repository completely and have my own plugin also contribute to TypeScript.

[angelozerr]

I think it should b ebetter to create a new class IDETypeScriptRepositoryManager which extends TypeScriptRepositoryManager which consume your extension point, no?

[angelozerr]

Please add EPL license like https://github.com/angelozerr/typescript.java/blob/master/core/ts.core/src/ts/TypeScriptKind.java and add your name.

[lorenzodallavecchia]

I have a doubt. There is already a TypeScriptRepositoryManager, but it currently has a "passive" role (the preference initializer populates it from the outside). Would you keep it that way and create a new different manager, or evolve it to auto-populate with TS repositories?

Personally I would go with the second option (evolving it), also making it similar to NodejsInstallManager.

[angelozerr]

Sorry for my too quick comments. Please re-read my propistion with IDETypeScriptRepositoryManager. TypeScriptRepositoryManager must not be linked to Eclipse (core folder could be consumed with other IDE)

[angelozerr]

Thanks so much @lorenzodallavecchia !

[angelozerr]

@lorenzodallavecchia I'm inegrating tslint by developping a TypeScript 2.3 plugin (not available for the moment), but I have found an hack to enable it (like angular2 language service).

The cool thing is that with my TypeScript 2.3 plugin, tslint is really well integrated with tsserver (the ts file is not parsed twice (once for completion, once for tslint), error appears when compile is done, (eclipse marker) and quick fixes starts working.

But I need to:

• add in the repository my tslint plugin language service
• update tsserver.js by adding a JS to load TypeScript 2.3 plugins

If you are interested with those features, I think we should discuss together about that (how to contribute to repository with new modules like tslint language service, etc) in order to you benefit with my tslint.

If you are interested with tslint, I will create a new issue to discuss about "how to contribute to repository with new module".

[lorenzodallavecchia]

Hi @angelozerr thanks for querying me on this. I hope the extension point change does not cause too much trouble in evolving typescript.java!

As long as the solution is based on extension points it should be OK for me.
The part about changing tsserver.js looks a little hacky though. I don't know much about TS plugins: is that the only way for integrating them?

For the moment I am not using tslint, but I plan to integrate it in our workflow in the future. So yes, I am interested in collaborating on this feature. :)

[angelozerr]

The part about changing tsserver.js looks a little hacky though.

I have found an elegant solution. Please wait that I finish to commit https://github.com/angelozerr/tsserver-plugins

For the moment I am not using tslint, but I plan to integrate it in our workflow in the future. So yes, I am interested in collaborating on this feature. :)

Ok, here a demo with Angular2 & tslint integration:

Hope you will like it:

[lorenzodallavecchia]

Amazing!
The way it understand about Angular templates is remarkable!

[angelozerr]

The way it understand about Angular templates is remarkable!

It's not my work but google& &microsoft work. Indeed it's amazing!

The tslint integration is my work. It uses microsoft/TypeScript#11976 which will be available in th efuture version of TypeScript but I have found a mean to consume those plugins with any version of TypeScript with https://github.com/angelozerr/tsserver-plugins