Skip to content

fix(build): Removed browser entry from package.json #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2017

Conversation

deini
Copy link
Collaborator

@deini deini commented Sep 1, 2017

Fix for #156:

So there were 2 issues, first the replace plugin has to go before other plugins such as commonjs.

Also we had browser in package.json which Webpack will default to when resolving modules, so instead of resolving to lib/ng-redux.js (main) or es/ng-redux.js (module) it was resolving to dist/ng-redux.js which we build with env set to development

"build:umd": "cross-env NODE_ENV=development rollup -c -o dist/ng-redux.js",

FYI @maxlapides

@deini deini requested a review from AntJanus September 1, 2017 19:30
@deini deini merged commit 3fde8bf into angular-redux:master Sep 4, 2017
@deini deini deleted the removeBrowser branch September 4, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant