fix(build): Removed browser entry from package.json #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #156:
So there were 2 issues, first the
replace
plugin has to go before other plugins such ascommonjs
.Also we had
browser
in package.json which Webpack will default to when resolving modules, so instead of resolving tolib/ng-redux.js
(main) ores/ng-redux.js
(module) it was resolving todist/ng-redux.js
which we build with env set todevelopment
ng-redux/package.json
Line 20 in e1973f7
FYI @maxlapides