switch to babel transform runtime Fixes #152 #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
babel-transform-runtime
branch
from
add33f5 to
acd9f9d
Compare
|
3.5.0 broke this package in IE because Object.assign isn't variable. You need to enable transform-runtime to automatically shim the feature. |
graingert
force-pushed
the
babel-transform-runtime
branch
from
acd9f9d to
90c9f07
Compare
graingert
changed the title
|
Fixes #152 |
|
@deini ^ |
|
Looks good, can you remove the /dist changes please? We will push them when we cut a new release. |
This allows the use of Object.assign
graingert
force-pushed
the
babel-transform-runtime
branch
from
90c9f07 to
7fbdc10
Compare
|
@deini rebased and fixed. Looking forward to getting the dist files git-ignored in v4 |
|
Me too @graingert , thanks for updating this. |
|
@deini any chance of a release? |
|
@graingert I don't have npm access yet. I'll bug @AntJanus tomorrow :) |
|
or @wbuchwalter |
|
@deini I'm about to do a release. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.