Skip to content

Add both minified and non-minified version to dist, and update Bower.… #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2016

Conversation

mndewitt
Copy link
Contributor

Getting started on #46, just adding non-min and min versions to dist and updating the naming convention. Should the non-minified version be included in the dist script, or in another property?

@wbuchwalter
Copy link
Member

Cool!
Ideally, it would be cleaner to split the scripts a little bit yea.
Something like:

{
"build": "npm run build:lib && npm run build:min & npm run build:max",
"build:lib": "rm -rf lib && `npm bin`/babel src --out-dir lib",
"build:min": "./node_modules/.bin/webpack --optimize-minimize lib/index.js dist/ng-redux.min.js",
"build:max": "./node_modules/.bin/webpack lib/index.js dist/ng-redux.js"
}

What do you think?

@mndewitt
Copy link
Contributor Author

Yeah, I like that approach - branch is updated. You okay then with: "dist": "npm run build"

@wbuchwalter
Copy link
Member

You can just remove dist at this point, it's not needed anymore.
Everything else looks good 👍

@mndewitt
Copy link
Contributor Author

Sweet, all set :)

wbuchwalter added a commit that referenced this pull request Jan 31, 2016
chore(build): Add both minified and non-minified version to dist, and update Bower.…
@wbuchwalter wbuchwalter merged commit 3e39fb1 into angular-redux:master Jan 31, 2016
@wbuchwalter
Copy link
Member

Thx! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants