Repository navigation
Extend peer dependencies to Angular 7 #547
Description
This is a...
- feature request
- bug report
- usage question
What toolchain are you using for transpilation/bundling?
- @angular/cli
- Custom @ngTools/webpack
- Raw
ngc - SystemJS
- Rollup
- Other
Environment
NodeJS Version: 10.9.0
Typescript Version: 3.1.6
Angular Version: 7.0.3
@angular-redux/store version: 9.0.0
@angular/cli version: 7.0.5
OS: Windows 10
Expected Behaviour:
No warnings should be shown
Actual Behaviour:
running npm install throws the following warning:
npm WARN @agm/core@1.0.0-beta.5 requires a peer of @angular/common@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @agm/core@1.0.0-beta.5 requires a peer of @angular/core@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself
Additional Notes:
Need to add support for Angular7, there is no big difference between v6 and v7, and package already have support for v6.
We should make sure to update codelyzer package to 4.5.0 to work with Angular 7 too.
Activity
phutaneVinayak commentedon Mar 1, 2019
try to remove the ~ from your package.json and add ^ their.
see below stackoverflow link
https://stackoverflow.com/questions/50307123/angular-5-npm-install-requires-peer-issue
kirillgroshkov commentedon Mar 4, 2019
Well, it's a warning, it still works, but nicer to not have this warning, since it works.
So, we should just change peerDependencies definition in
package.json. Is there any PR about it already? If not - should be trivial to add.I can confirm that we're using it with Angular7 and it works seamlessly.