Skip to content

Update floor label so that it hides correctly when using single slider. #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2015

Conversation

kaspertygesen
Copy link
Contributor

Initial state:
initial state

After change
after change

Before change
before change

@kaspertygesen
Copy link
Contributor Author

<rzslider
 rz-slider-floor="volumeSlider.floor"
 rz-slider-ceil="volumeSlider.ceil"
 rz-slider-model="volumeSlider.min"
 rz-slider-step="50"
 rz-slider-always-show-bar="true"
 rz-slider-translate="volumeSlider.translate"></rzslider>
    $scope.volumeSlider = {
        min: 4000,
        floor: 50,
        ceil: 4000,
        step: 50,
        translate: function (value) {
            if (value == 50) {
                return "below 50 l";
            }
            if (value == 4000) {
                return $filter('translate')('GLOBAL_ALL');
            }

            return value + " l";
        }
    };

@ValentinH
Copy link
Member

Could you please directly provide a JSFiddle showing the issue?

@ValentinH
Copy link
Member

Here what I copied from your second message: http://jsfiddle.net/dc089Lnv/
But I don't see the issue.

@kaspertygesen
Copy link
Contributor Author

Ok, it seems like its only a problem when used with the Ionic framework and modal dialogs.
Outside the modal it works just fine as in your jsfiddle.

I have reproduced it here:
http://plnkr.co/edit/WuaObGDkXMitYctKrFUz?p=preview

@ValentinH
Copy link
Member

OK I see, if it fixes you issue, we can add it. Anyway, I don't understand why it was only calling updateCeilLab()...

Can you run grunt to generate the dist files and add them to the PR? Then I'll merge it.

@kaspertygesen
Copy link
Contributor Author

Ye, that is what it thought as well.
Dist files added.

Thanks for maintaining this great project!

ValentinH added a commit that referenced this pull request Oct 16, 2015
Update floor label so that it hides correctly when using single slider.
@ValentinH ValentinH merged commit 4d13628 into angular-slider:master Oct 16, 2015
@ValentinH
Copy link
Member

You're welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants