Skip to content

Compatibility issue with ngAnimate #3647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UnbearableBear opened this issue May 30, 2015 · 1 comment
Closed

Compatibility issue with ngAnimate #3647

UnbearableBear opened this issue May 30, 2015 · 1 comment
Assignees
Milestone

Comments

@UnbearableBear
Copy link

Hey there :)
First of all, thanks for that grid, it's awesome !
I'm working with Angular 1.4 and so far, so good. However, there seems to be an issue with the last version of ngAnimate which have, apparently, made important changes. (I cannot use older version of ngAnimate because of compatilbility issues, lucky me to work on high tech projects :D)
I've made a plunker. You can try to remove this line of code in the index file to check how animation is supposed to look like:
<div class="grid" ui-grid="{data: ctrl.data}"></div>
But as soon as the table kicks in, animations go on a strike :o I assume it's because of styles injected via javascript but not sure, I don't have the time to dive any deeper :s

http://plnkr.co/edit/EXeheuc2rA5N8bO6Mb8k?p=preview

Anyway, thanks for the help and that magnificient grid !

@c0bra
Copy link
Contributor

c0bra commented Jun 2, 2015

Looks like 1.4.0 changed the order of parameters in $animate.enabled().

See: https://code.angularjs.org/1.4.0/docs/api/ng/service/$animate#enabled
vs:
https://code.angularjs.org/1.3.14/docs/api/ngAnimate/service/$animate#enabled

It was changed with this commit: angular/angular.js@c8700f0

I guess we'll have to do a version check to determine how to call it? BLEGH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants