This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Fixed issue with input on Android devices putting cursor behind the input. #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be fixing the same thing as #191 but does so with what seems MUCH less changes.
I realized that on my Samsung Galaxy S6 device, that any input (such as your phone number input on your demo site) the cursor would end up getting behind the input. I finally debugged the issue and realized that my device is actually "selecting" the character that is being input. What happens is this causes a different value for the
input.selectionStart
vsinput.selectionEnd
. When you are trying to get the caret position, you were using theinput.selectionStart
which ends up being at the beginning of the input character (which causes this issue).It seems that you can solve all use cases by changing this to
input.selectionEnd
which will give you the end of any selection and the correct caret position.