This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix direction-up in webkit #1163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixed the issue for me, please bring into master |
|
+1 - this fixed for me too! it's working. Please, new version. |
|
Can you remove /dist files from commit and just leave the /src files changes? |
|
Btw, did you tried on IE also? |
littlebigbot
force-pushed
the
fix/direction-up-webkit
branch
from
13125f8 to
4bb068b
Compare
|
@dimirc Removed that commit. And no, I haven't tested it with IE, but that function is from jqLite/jQuery, so it should work in IE... |
|
@littlebigbot Anyway thanks for checking this, I just pushed a PR that should solved #1212 this problem |
|
👍 Sounds good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like this: #989, but confirmed to work in Firefox