This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Noblecraft/1192 #1193
Closed
Noblecraft/1192 #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ uis.directive('uiSelect', | |||
|
|
|||
| //Multiple or Single depending if multiple attribute presence | |||
| if (angular.isDefined(tAttrs.multiple)) | |||
| tElement.append("<ui-select-multiple/>").removeAttr('multiple'); | |||
| tElement.append("<ui-select-multiple dict=\"" + tAttrs.dict + "\"/>").removeAttr('multiple'); | |||
There was a problem hiding this comment.
Should switch to single quote strings to avoid the awkward escaping of the double quote.
|
This needs changes to dist reverted, rebasing, and tests added for this new feature. |
|
Closing as I don't think this is a particular good solution to the problem. Let's see if anyone else is able to come up with something else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a proposed fix for issue #1192
sorry its a bit messy, first time contributing to ui-select.