This repository was archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelectSingle): Tagging without multiple with new tags doesn't works #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orks Tagging in single select is not working which has been testing in latest version of angular. Here, I've just copied working version of code from uiSelectMultiple directive and removed some code which causes the problem. All the test has been passed. Examples are working fine Closes angular-ui#1409, angular-ui#890
|
The tagging example, Tagging in Single select mode with new tags doesn't work. You can fix it? |
|
Yes, this has been fixed in my commit and I have sent pull request. Moderator have to check it, if everything is ok, he/she can merge it to master. |
|
I have tried, But It still does not work when Tagging in Single select mode, with simple strings |
|
Closing for now since it doesn't work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagging in single select is not working which has been testing in latest version of angular. Here, I've just copied working version of code from uiSelectMultiple directive and removed some code which causes the problem.
All the test has been passed. Examples are working fine
Closes #1409, #890