Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

support ng-required validator - fixes #258 #1764

Closed
wants to merge 1 commit into from
Closed

support ng-required validator - fixes #258 #1764

wants to merge 1 commit into from

Conversation

insidewhy
Copy link

@insidewhy insidewhy commented Aug 12, 2016

fixes #258, at least for single-entry ui-selects.

I took the work from @zgbjgg but applied to the correct files in src and fixed the whitespace/grammar.

I've verified the tests still pass with gulp but didn't include the changed files in dist in that commit. Would be very grateful if you could release 0.19.2 with this fix.

@insidewhy
Copy link
Author

Let me know if you want me to commit the files in dist and if so, whether I should merge the commits together or apply the updated dist files in a second commit.

@insidewhy
Copy link
Author

Sorry ignore this PR for now, after testing the changes they don't seem to work for me.

@insidewhy
Copy link
Author

I'll try again with a new PR based on my own work... I'm not seeing any of the form[fieldName] fields.

@insidewhy insidewhy closed this Aug 12, 2016
@user378230
Copy link
Contributor

You may want to review angular documentation for ngRequired: https://docs.angularjs.org/api/ng/directive/ngRequired

Note all PRs need tests as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng-required not validating form on submit
2 participants