This repository was archived by the owner on Oct 2, 2019. It is now read-only.
feat: Include padding when resizing multiple input #1872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the hard-coded 10px when accounting for padding, and use the calculated padding size instead, in case the theme has been overridden. Note that the test appends the generated uiSelectMultiple to the DOM (and later removes it) so that getComputedStyle functions normally.
|
These four failing tests (which are not related to this PR) seem to happen on a fresh checkout from master now. Not sure why, but I think it's probably a dependency-version thing. I will be investigating further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the hard-coded 10px when accounting for padding, and use the calculated padding size instead, in case the theme has been overridden.
Note that the test appends the generated uiSelectMultiple to the DOM (and later removes it) so that getComputedStyle functions normally.