-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Select first option no mater if it creates new tag or offers existing… #1915
Conversation
…one. Addresses issue angular-ui#1911
The 4 failing tests had been failing on master, they are not caused by the PR |
Hi @ilinsky I think i have found the reason for the failing unit tests. Waiting for some comments why things have changed after this we can probably rebase your PR and the unit test problem will be resolved. Thanks. |
Hi @ilinsky sorry to keep you waiting. Please rebase your PR with the latest changes this should solve the build problem. After that I will have a look at your PR. Thanks. |
Hi @Jefiozie It is done. |
Will this also solve #1887 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know have made some changes previous for disabled items. Did you check this without tagging and disabled items?
Any updates on this issue? Thanks |
Nope, did not do any further checks. Can you elaborate on what needs to be verified? |
In the example you can see the Next to this I would like some test also for the single select and multiple select if possible? |
I tried examples and it is my understanding everything works. |
Hi guys, any updates on this? |
…one. Addresses issue #1911