Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Select first option no mater if it creates new tag or offers existing… #1915

Merged
merged 2 commits into from
Mar 5, 2018

Conversation

ilinsky
Copy link
Contributor

@ilinsky ilinsky commented Feb 17, 2017

…one. Addresses issue #1911

@ilinsky
Copy link
Contributor Author

ilinsky commented Feb 17, 2017

The 4 failing tests had been failing on master, they are not caused by the PR

@Jefiozie
Copy link
Contributor

Hi @ilinsky I think i have found the reason for the failing unit tests. Waiting for some comments why things have changed after this we can probably rebase your PR and the unit test problem will be resolved.

Thanks.

@Jefiozie
Copy link
Contributor

Jefiozie commented Mar 7, 2017

Hi @ilinsky sorry to keep you waiting. Please rebase your PR with the latest changes this should solve the build problem. After that I will have a look at your PR.

Thanks.

@ilinsky
Copy link
Contributor Author

ilinsky commented Mar 7, 2017

Hi @Jefiozie It is done.

@Jefiozie
Copy link
Contributor

Jefiozie commented Mar 7, 2017

Will this also solve #1887

Copy link
Contributor

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know have made some changes previous for disabled items. Did you check this without tagging and disabled items?

@Jefiozie
Copy link
Contributor

Any updates on this issue?

Thanks

@ilinsky
Copy link
Contributor Author

ilinsky commented Mar 13, 2017

Nope, did not do any further checks. Can you elaborate on what needs to be verified?

@Jefiozie
Copy link
Contributor

In the example you can see the Disabling instead of removing selected items will this still work on the changes you have made?

Next to this I would like some test also for the single select and multiple select if possible?
Thanks.

@ilinsky
Copy link
Contributor Author

ilinsky commented Mar 15, 2017

I tried examples and it is my understanding everything works.

@joaopgg
Copy link

joaopgg commented Apr 19, 2017

Hi guys, any updates on this?

@Jefiozie Jefiozie merged commit d8fed30 into angular-ui:master Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants