Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

#258 Validates ng-required when multiple is used. #422

Closed
wants to merge 1 commit into from
Closed

#258 Validates ng-required when multiple is used. #422

wants to merge 1 commit into from

Conversation

richardallen
Copy link

This PR overrides NgModelController.$isEmpty when multiple is used so validation with ng-required works as expected.

@davisford
Copy link

LGTM

davisford added a commit to davisford/ui-select that referenced this pull request Dec 8, 2014
@davisford
updated pr with ui-elect master from angular-ui#422
5c913b5
@Rodeoclash
Copy link

+1

@davisford
Copy link

FWIW, I forked and merged upstream/master and created a feature branch that merges @richardallen's PR in -- so it should resolve the merge conflicts. If it helps any, I can send that PR which shouldn't have merge conflicts. It looks like since this PR was sent, the code got shuffled around a bit.

@abobwhite
Copy link

+1 Can we verify this works and get it merged?

@slawekkolodziej slawekkolodziej mentioned this pull request Jun 19, 2015
Closed
@user378230
Copy link
Contributor

#1492 merged

@user378230 user378230 closed this Mar 20, 2016
vanschroeder pushed a commit to Blue-Rocket/ui-select that referenced this pull request May 10, 2016
updated angular dependency version to v1.5.5 re: angular-ui#422
931d8a4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardallen @davisford @Rodeoclash @abobwhite @user378230