This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Issue/#624 - Add extra handling for negative activeIndex. #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JeromeLam - I'm in a meeting ATM, but first-glance is that this will merge without issue. Thanks for the assist, you caught what I missed 👍 |
brianfeister
pushed a commit
that referenced
this pull request
Feb 6, 2015
Issue/#624 - Add extra handling for negative activeIndex.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #624, which is specific to tagging. I verified the change against the basic demo.html file and there is no impact.
To @brianfeister's comment in #624, I tested successfully
tagging-label="{whatever}"andtagging-label="false"using the two first sections in demo-tagging.html.