Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

fix(tagging): allow to decline tag creation #678

Merged
merged 1 commit into from
Feb 18, 2015
Merged

Conversation

dimirc
Copy link
Contributor

@dimirc dimirc commented Feb 18, 2015

Rebase of @alexcrown PR #663 "Allow discard tag when tagging function returns null"

Related to #485

@dimirc dimirc added this to the 0.9.9 milestone Feb 18, 2015
dimirc added a commit that referenced this pull request Feb 18, 2015
fix(tagging): allow to decline tag creation
@dimirc dimirc merged commit 246b9e8 into master Feb 18, 2015
@dimirc dimirc deleted the fix-tagging-decline branch February 18, 2015 03:40
@LeleDev
Copy link

LeleDev commented Feb 19, 2015

I've updated ui-select to 0.9.9 but, when the tagging function returns null, I get the following error: Uncaught TypeError: Cannot set property 'isTag' of null

@dimirc
Copy link
Contributor Author

dimirc commented Feb 19, 2015

@LeleDev Can you setup a plunker reproducing this to check it? Also can you better open a new issue to keep track of this possible bug?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants