This repository was archived by the owner on Oct 2, 2019. It is now read-only.
If tagging mode is activated, do not check values #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2015
|
👍 I definitely need this, hope it lands soon! Good work! |
Asimov4
force-pushed
the
preserve-model-when-tagging
branch
2 times, most recently
from
a39bc0a to
9c18723
Compare
|
Just checking, there is no action needed on my side, right? The pull may make it in the next release? |
|
@Asimov4 According to my view there are merge conflicts - you might need to rebase on the current master branch. |
Asimov4
force-pushed
the
preserve-model-when-tagging
branch
3 times, most recently
from
a8510a4 to
061f792
Compare
|
I reapplied the change on top of the HEAD of master. |
Asimov4
force-pushed
the
preserve-model-when-tagging
branch
from
99aebc2 to
061f792
Compare
Motivation: Fix angular-ui#540 The tagging mode is designed to allow new values to be added to the model. It does not make sense to check those values against the list of choices when going from model --> view. Conflicts: src/uiSelectMultipleDirective.js
Asimov4
force-pushed
the
preserve-model-when-tagging
branch
from
061f792 to
866bc5c
Compare
|
I pulled the latest changes and the unit tests passed without my change so I guess this is fixed. |
|
@user378230 this looks good, just adds a test for desired behavior & may close out #540. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Fix #540
The tagging mode is designed to allow new values to be added to the model.
It does not make sense to check those values against the list of choices when going from model --> view.