enable declarationMap in workspace libraries

[xiaoxiangmoe]

🚀 Feature request

Command (mark with an x)

• new
• build
• serve
• test
• e2e
• generate
• add
• update
• lint
• xi18n
• run
• config
• help
• version
• doc

Description

see https://www.typescriptlang.org/v2/tsconfig#declarationMap

You should strongly consider turning this on if you’re using project references.

ng generate library my-lib will add path mapping in tsconfig.json. So we should enable declarationMap

[alan-agius4]

Duplicate of ng-packagr/ng-packagr#1464

[alan-agius4]

Actually let's re-open this, since it's slightly different but block it on ng-packagr/ng-packagr#1464

[alan-agius4]

Also, this needs some digging to see if it's even useful since we don't use project references.

[xiaoxiangmoe]

I included these files in my npm package:

• ts source code
• compiled js code
• .d.ts file
• map files of js and .d.ts

When I use this npm library, I can jump directly to the ts source code by VSCode Go to Definition, which is very convenient.

[xiaoxiangmoe]

Also, should we use Project References in angular?

[alan-agius4]

should we use Project References in angular?

No, the Angular CLI / Compiler don't support composite projects.

I do see, that they can be useful in a monorepo, however, when shipping a library I don't think that dts maps will add any value unless you also ship the typescript source files.

[alan-agius4]

We had a chat around this yesterday and we decided that we should enable declarationMap for non production builds.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}