chore: extra broccoli plugins from angular/angular #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that we should merge this in and later clean up the mess by pulling broccoli plugins via npm (currently these plugins are not on npm because I want to make some big changes in them and don't want to deal with npm and backwards compatibility) |
the most interesting and the one we need for improving the testing story is the broccoli-dest-copy plugin - this enables angular#87 these plugins were built at the same time as broccoli-typescript plugin updated in 563e6e2
IgorMinar
force-pushed
the
extra-broccoli-plugins
branch
from
e28162e to
2d8d45f
Compare
|
lgtm |
|
Is this PR still up to date? If so, since @cironunes has already given his lgtm, then all that is missing for merge is a rebase. |
clydin
pushed a commit
that referenced
this pull request
Jun 5, 2018
…109) This one is recommended in the style guide. https://angular.io/guide/styleguide#style-02-05 If it's part of the blueprint, it'd be better.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the most interesting and the one we need for improving the testing story is the broccoli-dest-copy plugin - this enables #87