Fix 11034 #11648
Merged
Fix 11034 #11648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble no-any Not entirely removed the usage of any but its a step in the right direction.
hansl
force-pushed
the
fix-11034
branch
2 times, most recently
from
dec1bc1 to
c21bee7
Compare
filipesilva
suggested changes
Jul 25, 2018
| } | ||
|
|
||
| if (!isSameBuilder) { | ||
| throw new Error('Architect commands with multiple targets cannot specify overrides.' |
There was a problem hiding this comment.
Can you change this error message to indicate that the problem is not the multiple targets, but rather that they have different builders?
| return Promise.resolve() | ||
|
|
||
| // setup a double-quote tslint config | ||
| .then(() => writeFile('src/app/tslint.json', nestedConfigContent)) | ||
| .then(() => writeFile('tslint.json', nestedConfigContent)) |
There was a problem hiding this comment.
Nit: being at toplevel means it's not a tested config anymore.
It makes sense and is the only way to allow "ng lint --fix". If the builder is the same for all targets, overrides are allowed.
Before we only allowed tsconfig files (with includes added). This is necessary for the lint fixing for schematics to target specific files. Also added a feature that look for the tslint.json file if no tslint.json file or configuration object was passed. Skipping the first argument to the task constructor will look for the tslint closest to EVERY files being linted.
filipesilva
approved these changes
Jul 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for more information.
Fixes #11034