Skip to content

fix(@angular-devkit/build-angular): update node-sass #11831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Aug 9, 2018

See sass/node-sass#2355 for context.

Fix #11699
Related to #10963

@filipesilva filipesilva force-pushed the node-sass-security-update branch from 838f27e to 1b37e99 Compare August 9, 2018 13:18
hansl
hansl previously approved these changes Aug 9, 2018
@alexeagle
Copy link
Contributor

Sorry, would you resolve the conflicts pls @filipesilva

@filipesilva filipesilva added the target: patch This PR is targeted for the next patch release label Aug 14, 2018
@alexeagle alexeagle merged commit 711d0c0 into angular:master Aug 15, 2018
@alexeagle
Copy link
Contributor

Doesn't patch into 6.1.x branch because there is no yarn.lock file there. Skipping this for the 6.1.4 release.

alexeagle pushed a commit to alexeagle/angular-cli that referenced this pull request Aug 15, 2018
@filipesilva filipesilva deleted the node-sass-security-update branch August 16, 2018 09:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github security warning for hoek
5 participants