Skip to content

chore(routes): remove lazy route prefix #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Sep 1, 2016

No description provided.

@johnpapa
Copy link
Contributor

johnpapa commented Sep 1, 2016

LGTM

@Brocco Brocco force-pushed the remove-lazy-route-prefix branch from 0a7c3f2 to acf01bc Compare September 1, 2016 02:50
@Brocco Brocco merged commit 440d767 into angular:master Sep 1, 2016
@Brocco Brocco deleted the remove-lazy-route-prefix branch September 1, 2016 03:17
@elvirdolic
Copy link

@Brocco what are the reasons for this Pull Request? Are there any instructions/migration steps for us who have already routes with (+) prefix?

@intellix
Copy link
Contributor

intellix commented Sep 1, 2016

@elvirdolic You need to migrate to NgModule first :) The old router lazy loaded components by expecting a + folder prefix. New router just lazy-loads modules at the specified location.

@Brocco
Copy link
Contributor Author

Brocco commented Sep 1, 2016

@elvirdolic the + prefix for lazy routes was a convention devised for a previous version of the router and before the concept of NgModules was introduced.

The idea of that indicator no longer makes sense. Lazy routes are now associated to lazy modules and the need for this indicator is no longer necessary.

@Meligy
Copy link
Contributor

Meligy commented Sep 1, 2016

Don't you think a naming convention for lazy loading would be useful?

This is probably a styleguide question though, which I'm not sure where will be best to discuss.

@bobrosoft
Copy link

I think naming convention for that kind of stuff was a bad idea, so I completely agree with that PR.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants