Fix for webpack 5 + babel "failed to resolve" error #20810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@googlebot I signed it! |
alan-agius4
reviewed
May 17, 2021
packages/angular_devkit/build_angular/src/webpack/configs/common.ts
Outdated
Show resolved
Hide resolved
alan-agius4
requested changes
May 17, 2021
There was a problem hiding this comment.
Hi @buu700,
Can you please fix the validation CI by updating your commit to;
fix(@angular-devkit/build-angular): correctly resolve babel runtime helpers
Closes #20800
alan-agius4
added
the
action: cleanup
|
Done, thanks @alan-agius4! |
alan-agius4
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #20800.
I don't know if this is the best fix for this issue, but seems to be an effective temporary workaround at least. It's possible that a bug may need to be fixed in
babel-loaderor@babel/runtime.