Skip to content

refactor(@angular-devkit/build-angular): remove usage of rimraf package #21049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2021
Merged

refactor(@angular-devkit/build-angular): remove usage of rimraf package #21049

merged 1 commit into from
Jun 4, 2021

Conversation

alan-agius4
Copy link
Collaborator

Use Node.JS rmdirSync instead.

@alan-agius4 alan-agius4 requested a review from clydin June 4, 2021 12:01
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed cla: yes labels Jun 4, 2021
@google-cla google-cla bot added the cla: yes label Jun 4, 2021
@angular angular deleted a comment from google-cla bot Jun 4, 2021
clydin
clydin approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove the package from the root package.json as well now.

@alan-agius4
Copy link
Collaborator Author

It’s being used by a number of e2e tests

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 4, 2021
@alan-agius4 alan-agius4 merged commit c0106f6 into angular:master Jun 4, 2021
@alan-agius4 alan-agius4 deleted the rimraf-build-angular branch June 4, 2021 13:37
@terencehonles terencehonles mentioned this pull request Jun 26, 2021
Closed
15 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alan-agius4 @clydin