Skip to content

build: use npm_package instead of js_library for the scheamtics npm package #30136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: use npm_package instead of js_library for the scheamtics npm package #30136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ esbuild_register_toolchains(

git_repository(
name = "rules_angular",
commit = "bc8e690770319b8780761f797773bfd47f47dfdc",
commit = "005c80615934c891d729d5efc1ae661f9e3210c4",
remote = "https://github.com/devversion/rules_angular.git",
)

Expand Down
8 changes: 4 additions & 4 deletions packages/angular/ssr/schematics/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Use of this source code is governed by an MIT-style license that can be
# found in the LICENSE file at https://angular.dev/license

load("@aspect_rules_js//js:defs.bzl", "js_library")
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
load("//tools:defaults.bzl", "jasmine_test", "ts_project")
load("//tools:ts_json_schema.bzl", "ts_json_schema")

Expand Down Expand Up @@ -91,9 +91,9 @@ jasmine_test(
],
)

# This target is used as nested_package in the main @angular/ssr package as a dep.
js_library(
name = "pkg",
# This package is intended to be combined into the main @angular/ssr package as a dep.
npm_package(
name = "npm_package",
srcs = [
"package.json",
":schematics",
Expand Down
Loading