Skip to content

build: update aspect_rules_js to 3.0.2#32716

Merged
alan-agius4 merged 2 commits intoangular:mainfrom
alan-agius4:rules_js3
Mar 9, 2026
Merged

build: update aspect_rules_js to 3.0.2#32716
alan-agius4 merged 2 commits intoangular:mainfrom
alan-agius4:rules_js3

Conversation

@alan-agius4
Copy link
Collaborator

This updates the major version of aspect_rules_js.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 6, 2026
This updates the major version of `aspect_rules_js`.
@alan-agius4 alan-agius4 marked this pull request as ready for review March 9, 2026 08:59
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 9, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates aspect_rules_js to version 3.0.2, a major version update. The changes primarily involve dependency updates and necessary code adjustments to accommodate breaking changes, such as migrating from @aspect_bazel_lib to @bazel_lib and updating environment variable checks for Bazel. The refactoring of test assets and improvements in dependency resolution are also noted. I've identified one area for improvement to further align with the migration away from deprecated libraries.

Note: Security Review did not run due to the size of the PR.

@alan-agius4 alan-agius4 force-pushed the rules_js3 branch 4 times, most recently from eab341c to 362664d Compare March 9, 2026 12:44
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 9, 2026
@alan-agius4 alan-agius4 merged commit e59f77a into angular:main Mar 9, 2026
36 checks passed
@alan-agius4 alan-agius4 deleted the rules_js3 branch March 9, 2026 14:24
@alan-agius4
Copy link
Collaborator Author

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants