feat(@angular/build): share persistent build cache across git worktrees#33519
Open
clydin wants to merge 1 commit into
Open
feat(@angular/build): share persistent build cache across git worktrees#33519clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
This change automatically resolves the default persistent cache directory relative to the common git directory (the main repository root) instead of the worktree root when a Git worktree is detected. This prevents cache duplication across multiple checkouts/worktrees of the same repository. Closes angular#33321
angular-robot
Bot
added
detected: feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for resolving the Angular cache path relative to the main repository root when working within a Git worktree. It introduces a helper function getCacheBasePath in both the build and CLI utilities to traverse directories, parse .git files, and locate the common Git directory if a worktree is detected. Comprehensive unit tests are also added. The review feedback points out that wrapping the entire directory traversal loop in a try...catch block could prematurely abort the search on file system errors (such as permission issues). It is recommended to scope the try...catch block to individual file system operations inside the loop to ensure robust traversal.
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change automatically resolves the default persistent cache directory relative to the common git directory (the main repository root) instead of the worktree root when a Git worktree is detected. This prevents cache duplication across multiple checkouts/worktrees of the same repository.
Closes #33321