perf(@angular/build): avoid encoding intermediate source maps before remapping - #33779
Open
clydin wants to merge 1 commit into
Open
perf(@angular/build): avoid encoding intermediate source maps before remapping#33779clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
…remapping Use `generateDecodedMap()` instead of `generateMap()` when intermediate source maps created with `MagicString` are immediately remapped via `@ampproject/remapping`. This applies to: - `oxc-transform`: when an input source map is present - `oxc-linker`: when an input source map is present - Sass URL rebasing: intermediate stylesheet rebase maps stored for Sass source map merging Bypassing VLQ base64 encoding and immediate decoding reduces CPU time and temporary memory allocations during source map generation.
angular-robot
Bot
added
area: performance
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request optimizes sourcemap generation and remapping across several build tools (including the OXC linker, OXC transform, and Sass rebasing importer) by switching from encoded sourcemaps to decoded sourcemaps (DecodedSourceMap). By utilizing generateDecodedMap instead of generateMap when an input sourcemap is present, it avoids unnecessary encoding and decoding overhead. Additionally, corresponding unit tests have been added to verify sourcemap generation and remapping behavior. There are no review comments, so I have no feedback to provide.
clydin
added
target: minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
generateDecodedMap()instead ofgenerateMap()when intermediate source maps created withMagicStringare immediately remapped via@ampproject/remapping.This applies to:
oxc-transform: when an input source map is presentoxc-linker: when an input source map is presentBypassing VLQ base64 encoding and immediate decoding reduces CPU time and temporary memory allocations during source map generation.