refactor(@angular/cli): consolidate config reading logic #5023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
force-pushed
the
config-refactor
branch
from
ef37d0f to
7de71ae
Compare
Brocco
force-pushed
the
config-refactor
branch
from
7de71ae to
22d4d22
Compare
hansl
suggested changes
Feb 28, 2017
| const cliConfig = CliConfig.fromProject(); | ||
| const ngConfig = cliConfig && cliConfig.config; | ||
| const appConfig = getAppFromConfig(ngConfig.apps, this.options.app); | ||
| const appConfig = getAppFromConfig(this.options.app); |
There was a problem hiding this comment.
I think this and all other lines like this can fit in one line now.
Brocco
force-pushed
the
config-refactor
branch
from
22d4d22 to
fe94f5a
Compare
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #5018