fix(@ngtools/webpack): Lazy load from node_modules

[pedroapy]

Based on code of PR #6609. Here's a possible solution for issue #6373

[hansl]

You're not verifying that a path component is node_modules, but just that node_modules is a substring. Could you use something like this._fileName.split(path.sep).indexOf('node_modules') >= 0?

[pedroapy]

Thank you, you're right, I just fixed it.

[rhinoandre]

So, what is missing to this PR be approved?

[choeller]

We are also very interested in this PR. @hansl As your comment was take care of, Could this be merged?

[mmayors]

Glad to see this PR has been opened, it would be really nice to support this out of the box without additional Webpack config / loaders.

[andresguibarra]

Hi, I'm working with multiple custom libraries and this PR would be very useful for me and many others.

[smkart]

This PR will be so helpful if it fix the issue, Can we have it with next build

Thanks for the help

[dotansimha]

@pedroapy @hansl any chance we can get it merged? :(

[andresguibarra]

@filipesilva any chance we can get it merged?

[clydin]

Thank you for the contribution. However, this is being closed as it is outdated and no longer applies to the current code base.

[mmayors]

@clydin may I ask why it's no longer applicable? Are there now other ways to lazy load NgModules that live outside the app src? (i.e. inside an NPM package / node_modules)

[clydin]

The changes in question were made to a file that no longer exists within the code base as it was used only for Angular versions less then 5. In addition the package in question has been moved to this repository: https://github.com/angular/devkit

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}