This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat(bower): add npm script for updating bower dependencies as well #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CloudBees URL doesn't seem to work any more. And the `CloudBees-community/angular-js-clickstart` (now moved to `CloudBees-attic`) relies on the patched `michaelneale/angular-seed`, which hasn't been updated for ~2.5 years and is more than 40 commits behind `angular/angular-seed`.
Previously, is was suggested to run `bower update`, which would only work if `bower` was globally installed. Since a global `bower` installation should not be a prerequisite for the seed project, it is now possible to update bower dependencies via the new `update-deps` npm script. Fixes angular#383
|
/cc @petebacondarwin |
| correctly. Therefore, our web server needs to be serving up the application, so that Protractor | ||
| can interact with it. | ||
| correctly. Therefore, our web server needs to be serving up the application, so that Protractor can | ||
| interact with it. Before starting Protractor, open a separate terminal window and run: |
There was a problem hiding this comment.
Is it worth putting this line in its own paragraph? And maybe even making it bold?
|
LGTM - one small suggestion |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes #383, by adding an npm script (
update-deps) for updating bower dependencies as well as npm ones. Previously, is was suggested (in README.md) to runbower update, which would only work ifbowerwas globally installed. Since a globalbowerinstallation should not be a prerequisite for the seed project, it is now possible to update bower dependencies via the newupdate-depsnpm script.The PR includes the following (mostly minor) docs changes in separate commits: