This repository was archived by the owner on Dec 4, 2017. It is now read-only.
Restyle api docs for classes and directives #1089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| module.exports = [ | |||
| require('./deprecated'), | |||
| require('./howToUse'), | |||
| require('./whatItIs'), | |||
| require('./whatItDoes'), | |||
There was a problem hiding this comment.
I realized the naming mistake after looking more closely at the api doc proposal document in #964
|
@wardbell this looks good to me -- I won't have time to merge it until late today. If convenient, could you merge and verify with check-deploy? (but no rush if you are swamped) |
|
Merged and live! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a live test link if you'd like to check it out: https://api-doc-styling-1.firebaseapp.com/
This PR is work towards closing #964, as it stands, there are already quite a bit of changes in the codebase. This is in an effort to make code review easier. I will continue fulfilling the proposal in #964 in a subsequent PR.