Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Add breaking change notes to docs for commit 531a8de72c439d8ddd064874bf364c00cedabb11 #11163

Closed
dnchristiansen opened this issue Feb 24, 2015 · 2 comments

Comments

@dnchristiansen
Copy link

Commit 531a8de introduced a breaking change where the $observe function no longer gets called even for attributes that aren't defined. There is a note about this on the github page, but there is nothing about it in either the changelog or the migration guide.

I have been working on migrating from 1.2 to 1.3 and it took me a while to track down an issue because of this new behavior. I think it's worth adding a breaking change note to the change log and adding this to the migration guide (https://docs.angularjs.org/guide/migration), so people can be made aware of this breaking change.

@ilanbiala
Copy link

Anything happening with this?

@Narretz Narretz self-assigned this Dec 7, 2015
@Narretz Narretz closed this as completed in 48ad748 Dec 7, 2015
@Narretz
Copy link
Contributor

Narretz commented Dec 7, 2015

I've added a BC note. Due to the nature of the docs, this will however only appear in the next 1.4 and 1.5 versions, not in the 1.3 version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants