This repository was archived by the owner on Apr 12, 2024. It is now read-only.
ng-transclude adds span element with ng-scope class #15223
Milestone
Comments
|
I don't think that we can fix this in 1.5.x since it would require a breaking change in the compiler. This is already solved in 1.6.x, which is nearing release. So I suggest that if you need this functionality you look to migrate to the newer version. |
andrewconnell
pushed a commit
to ngOfficeUIFabric/ng-officeuifabric
that referenced
this issue
Feb 20, 2017
Fixed the duplication of `uif-sort-order` icon due an upgrade on `ng-transclude` in Angular 1.6.x. This fix applies to Angular 1.5.x as well. See angular/angular.js#15223 for reference. Fixes #475.
andrewconnell
pushed a commit
to ngOfficeUIFabric/ng-officeuifabric
that referenced
this issue
Feb 20, 2017
Fixed the duplication of `uif-sort-order` icon due an upgrade on `ng-transclude` in Angular 1.6.x. This fix applies to Angular 1.5.x as well. See angular/angular.js#15223 for reference. Closes #475.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Note: for support questions, please use one of these channels: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#question. This repository's issues are reserved for feature requests and bug reports.
Do you want to request a feature or report a bug?
report a bug
What is the current behavior?
ng-transclude adds empty span for "basic" transclusion (#1293 regression) and for multi-slot transclusion in case of using fallback content (introduced in 1.5.8 by 159a68e)
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
Basic transclusion:
https://plnkr.co/edit/YRqaDYsdRJUotYwgntqV
Multi-slot with fallback content in 1.5.8:
https://plnkr.co/edit/NiJOif6IEbZhWAhhNHZt
For comparison - same case as above in 1.5.7:
https://plnkr.co/edit/kQhXKe0qA4Kg5aZ4zLVQ,
What is the expected behavior?
In my opinion ng-transclude should not add additional span elements (no matter which mode is being used - "basic" or "multi-slot")
What is the motivation / use case for changing the behavior?
Additional span introduced in 1.5.8 by 159a68e is breaking layout in our application.
Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
Angular 1.5.7, 1.5.8 - "Basic" transclusion. I'm pretty sure it worked properly in 1.4.X (?)
Angular 1.5.8 - Multi-slot transclusion
Other information (e.g. stacktraces, related issues, suggestions how to fix)
#1293 - related issue
The text was updated successfully, but these errors were encountered: