Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Remove a sudden listing of an attribute name next to its directive name. #1171

Closed
wants to merge 2 commits into from
Closed

Conversation

brettcannon
Copy link
Contributor

In the entire tutorial up to this point, it has been left up to the reader to map directive names to attribute names (except for the introduction of the concept in step 0). This patch keeps this consistency by removing the single instance thus far of bothering to list the directive name and attribute name directly next to each other.

@ProLoser
Copy link
Contributor

ProLoser commented Aug 5, 2012

Brett, looking at your fork you've got to single-handedly have like 40 patches. You should consider creating a branch like 'documentation-tweaks' and then just keep committing to that branch. It will make it easier for the core team to review these patches and will it more likely for them to be merged

@brettcannon
Copy link
Contributor Author

In hindsight that probably would have been better, but I'm done reading the tutorial and. I did all submissions through GitHub's wweb interface which does these separate branches.

@brettcannon brettcannon closed this Aug 5, 2012
@brettcannon brettcannon reopened this Aug 5, 2012
@brettcannon
Copy link
Contributor Author

In hindsight that may have been nicer, but I did all of my submissions through the web interface which does theses separate branches. Plus I'm currently done with patch submissions.

@mhevery
Copy link
Contributor

mhevery commented Aug 31, 2012

Thanks, merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants