This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(core): ensure that multiple requests to requestAnimationFrame are buffered #11800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
force-pushed
the
raf_perf
branch
2 times, most recently
from
297b3fc to
c5392a4
Compare
| var task = taskQueue[i]; | ||
| if (task) { | ||
| taskQueue[i] = null; | ||
| taskCount--; |
There was a problem hiding this comment.
The taskCount variable is essential to know when to cancel the underlying RAF request when there are no more queued rAF functions.
There was a problem hiding this comment.
But here you are running a loop that decreases taskCount and right after that you srt it to 0.
So, decrementing it is redundant.
matsko
force-pushed
the
raf_perf
branch
2 times, most recently
from
a882a93 to
0aeabd5
Compare
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
|
LGTM (from Igor in person). |
|
Merged in as db20b83 |
|
What does Igor in person think about Did I miss something ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 (and maybe some other browsers) do not optimize multiple calls to
rAF. This code makes that happen internally within the $$rAF service
before the next frame kicks in.
Closes #11791