Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input): patched input cjk binding bug on IE11 browser. (angularjs v1.4.4) #12660

Closed
wants to merge 1 commit into from

Conversation

powerumc
Copy link

Related #12659

I append "if condition" code about ie11.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@powerumc powerumc changed the title fix(input): patched input cjk binding bug fix(input): patched input cjk binding bug on IE11 browser. (angularjs v1.4.4) Aug 23, 2015
@Narretz
Copy link
Contributor

Narretz commented Aug 23, 2015

Dupe of #12661

@Narretz Narretz closed this Aug 23, 2015
@Narretz Narretz reopened this Aug 23, 2015
@Narretz
Copy link
Contributor

Narretz commented Aug 23, 2015

Oops, didn't see this was for master. We usually backport these fixes from master without an extra PR.

@powerumc
Copy link
Author

Do I have any problem for this pull request? :)

@powerumc powerumc closed this Aug 24, 2015
@powerumc powerumc reopened this Aug 24, 2015
@powerumc powerumc force-pushed the patch.cjk.input.v1.4.4 branch from acffa17 to 1757433 Compare August 25, 2015 17:03
@googlebot
Copy link

CLAs look good, thanks!

@Narretz
Copy link
Contributor

Narretz commented Apr 6, 2018

We've recently fixed an issue with IE and compositionevents. It's possible that this PR was obsoleted by it. However, it's difficult to tell because there are no tests in this PR. Closing then. Sorry we never properly triaged this,

@Narretz Narretz closed this Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants