This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Feat: parse / format / validation for ngModel collection values #12905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essing collection items Legacy p/f/v will receive the whole collection as argument, the new API allows to specify if collection items are handled. When the controller handles a collection it will set a special property $$viewValueCollection that is set to the collection that is returned by the first parser / last formatter, respectively. If there's no parser / formatter, assume that the viewValue / modelValue is already a collection. $$viewValueCollection represents the viewValue (which is usually a string), as a collection of single values, so validators that handle collection items can validate the viewValue of collection items.
Narretz
force-pushed
the
feat-model-collection-validation
branch
from
b7eb0a5 to
ae7b629
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12783
This change has two goals:
Regarding 1), it's currently a simple property $isCollection on the modelCtrl that does two things: it activates the deepWatch behavior, and informs the pfv that the model is a collection.
TODO: move $isCollection to ngModelOptions?
Regarding 2). There's a new API for pfv that makes it possible to decide if the whole model or single collection items are handled. These are simple classes that are added to the $parsers, $formatters pipelines respectively $validators collection as before. Legacy pfv continue to receive the whole collection as values for backward compat.
TODO: expose NgModelTransform, NgModelValidator to the public