This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore(build): add a validation step for angularFiles #13553
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@petebacondarwin and @IgorMinar please review. |
75c0791
to
b9ccade
Compare
b9ccade
to
e29d7a7
Compare
@@ -354,7 +406,7 @@ module.exports = function(grunt) { | |||
|
|||
grunt.registerTask('minify', ['bower','clean', 'build', 'minall']); | |||
grunt.registerTask('webserver', ['connect:devserver']); | |||
grunt.registerTask('package', ['bower','clean', 'buildall', 'minall', 'collect-errors', 'docs', 'copy', 'write', 'compress']); | |||
grunt.registerTask('package', ['bower', 'validate-angular-files','clean', 'buildall', 'minall', 'collect-errors', 'docs', 'copy', 'write', 'compress']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this PR, but there's a space missing before 'clean'
😁
This is missing a required change to npm shrinkwrap |
@@ -339,6 +341,56 @@ module.exports = function(grunt) { | |||
grunt.task.run('shell:npm-install'); | |||
} | |||
|
|||
grunt.registerTask('validate-angular-files', function() { | |||
var combinedFiles = Object.assign({}, files.angularModules); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use lodash here for assign()
, so no actual need for Node 4
Last thing is that I think the task should be in its own file in I have created a new PR with a number of these changes... |
matsko
added a commit
that referenced
this pull request
Dec 17, 2015
matsko
added a commit
that referenced
this pull request
Dec 17, 2015
matsko
added a commit
that referenced
this pull request
Dec 17, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output looks like this (when passing):
When failing (when a file is referenced in a module but doesn't exist in the local filesystem):
When failing (when a file exists locally but isn't used in any module):