This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(copy): handle multiple references to ArrayBuffers #13640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
13398
branch
2 times, most recently
from
39293d1 to
07e3a01
Compare
|
overall, it looks fine, but can you update the PR to reflect the fact that #13641 landed? |
|
Updated. Also added another test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #13398 I realized that typed arrays don't put copied ArrayBuffers onto the copy stack. So ArrayBuffers referenced from multiple TypeArrays wouldn't keep those references when copied.