This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(copy): fix typed subarrays handling #14845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it would return copy of the whole original typed array, not its slice. Now buffer offset and length are also saved. Closes #14842
| @@ -901,7 +901,7 @@ function copy(source, destination) { | |||
| case '[object Uint8ClampedArray]': | |||
| case '[object Uint16Array]': | |||
| case '[object Uint32Array]': | |||
| return new source.constructor(copyElement(source.buffer)); | |||
| return new source.constructor(copyElement(source.buffer), source.byteOffset, source.length); | |||
There was a problem hiding this comment.
Is length the same as byteLength (for non-uint8 arrays)?
There was a problem hiding this comment.
@gkalpak nope, source.byteLength = source.length * source.BYTES_PER_ELEMENT.
I've made some sample code to demo why source.length and not source.byteLength:
https://plnkr.co/edit/afWbk8OboJopB6BgSri7
|
Other than one minor comment, LGTM 👍 |
|
Hm.. no idea, what should I fix to make it pass. Works fine on my branch. |
|
@zhukov , it is probably a flake. I restarted the job. Thx for the changes 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
It copies the whole buffer, not a slice.
Here is the demo: http://plnkr.co/edit/nU76OITTchFc48jFab2a?p=preview
#14842
What is the new behavior (if this is a feature change)?
When copying typed subarray the new value has the same length as the initial typed array.
This is not a feature change.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
Previously, it would return copy of the whole original typed array, not its slice.
Now buffer offset and length are also saved.
Closes #14842