This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Remove expression sandbox #15094
Closed
Remove expression sandbox #15094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once it has a proper commit message and a couple of unused vars at the top of the file are removed (I only found some cached methods, that's all) I think it's ready to land. Performance improvements can be addressed in subsequent PRs/commits, I like that this one mostly cleanly removes stuff. Other than that, LGTM. |
petebacondarwin
force-pushed
the
remove-sandbox
branch
from
fdc3de8 to
794b770
Compare
|
The changes LGTM. Wrt the commit message:
|
|
@gkalpak - I always get that wrong :-(
|
The angular expression parser (`$parse`) attempts to sandbox expressions to prevent unrestricted access to the global context. While the sandbox was not on the frontline of the security defense, developers kept relying upon it as a security feature even though it was always possible to access arbitrary JavaScript code if a malicious user could control the content of Angular templates in applications. This commit removes this sandbox, which has the following benefits: * it sends a clear message to developers that they should not rely on the sandbox to prevent XSS attacks; that they must prevent control of expression and templates instead. * it allows performance and size improvements in the core Angular 1 library. * it simplifies maintenance and provides opportunities to make the parser more capable. Please see the [Sandbox Removal Blog Post](http://angularjs.blogspot.com/2016/09/angular-16-expression-sandbox-removal.html) for more detail on what you should do to ensure that your application is secure.
petebacondarwin
force-pushed
the
remove-sandbox
branch
from
794b770 to
10597de
Compare
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Feb 5, 2017
This is a follow-up to angular#15094.
3 tasks
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
…rse()` This is a follow-up to angular#15094. Closes angular#15680
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
refactor
What is the current behavior? (You can also link to an open issue here)
The angular expression parsers attempts to sandbox the expressions to prevent unrestricted access to the global context.
What is the new behavior (if this is a feature change)?
The sandbox is removed, as it was not a real security feature.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
TODO: