This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/scope) correct explanation of example #4839
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove reference to 'employee' property as it's not used in the example. Add $rootScope injection and definition of 'department' property mentioned in text. Fiddle example of change: http://jsfiddle.net/F9L7z/
Contributor
|
Nice one! |
petebacondarwin
pushed a commit
that referenced
this pull request
Nov 13, 2013
Remove reference to `employee` property as it's not used in the example. Inject and use `$rootScope` applying `department` property as mentioned in text. Closes #4839
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Remove reference to `employee` property as it's not used in the example. Inject and use `$rootScope` applying `department` property as mentioned in text. Closes angular#4839
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
Remove reference to `employee` property as it's not used in the example. Inject and use `$rootScope` applying `department` property as mentioned in text. Closes angular#4839
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reference to 'employee' property as it's not used in the example.
Add $rootScope injection and definition of 'department' property mentioned in text.
Fiddle example of change: http://jsfiddle.net/F9L7z/