This repository was archived by the owner on Apr 12, 2024. It is now read-only.
perf($scope): Add a property $$watchersCount to scope #5799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalfaso
force-pushed
the
watch-perf
branch
from
57276b9 to
02a5a97
Compare
|
rebase and added a few benchmarks |
lgalfaso
force-pushed
the
watch-perf
branch
from
02a5a97 to
014b38b
Compare
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
This looks interesting. @lgalfaso, is it still relevant? |
|
@IgorMinar it does make a difference when there are a lot of bind-once expressions. Will rebase it on top of trunk |
|
rebase on top of master |
|
Do we have a benchmark that shows the impact?
|
|
@IgorMinar the new test and the existing bind-once test show a big performance boost. That said, the test is is synthetic so the real world performance improvements will be a lot smaller |
Add a property $$watchersCount to scope that keeps the number of watchers in the scope plus all the child scopes. Use this property when traversing scopes looking for watches
|
This looks good. I need to give it a run out first. |
|
landed as c1500ea |
lgalfaso
added a commit
that referenced
this pull request
Jan 30, 2015
Add a property $$watchersCount to scope that keeps the number of watchers in the scope plus all the child scopes. Use this property when traversing scopes looking for watches Closes: #5799
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property $$watchersCount to scope that keeps the number of watchers in the scope plus all the child scopes. Use this property when traversing scopes looking for watches