Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input): treat all not number model as blank #656

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/widget/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -594,9 +594,9 @@ function numericRegexpInputType(regexp, error) {
};

widget.$parseModel = function() {
if (isNumber(widget.$modelValue)) {
widget.$viewValue = '' + widget.$modelValue;
}
widget.$viewValue = isNumber(widget.$modelValue)
? '' + widget.$modelValue
: '';
};
}];
}
Expand Down
12 changes: 12 additions & 0 deletions test/widget/inputSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,18 @@ describe('widget: input', function() {
});
});

describe('number', function(){
it('should clear number on non-number', inject(function($compile, $rootScope){
$rootScope.value = 123;
var element = $compile('<input type="number" ng:model="value" >')($rootScope);
$rootScope.$digest();
expect(element.val()).toEqual('123');
$rootScope.value = undefined;
$rootScope.$digest();
expect(element.val()).toEqual('');
}));
});


it('should ignore text widget which have no name', function() {
compile('<input type="text"/>');
Expand Down