This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): mark empty expressions as constants and literals #7762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -989,7 +989,7 @@ function getterFn(path, options, fullExp) { | |||
| * service. | |||
| */ | |||
| function $ParseProvider() { | |||
| var cache = {}; | |||
| var cache = {'': extend(function () {}, {literal: true, constant: true})}; | |||
There was a problem hiding this comment.
I didn't want to add an extra code path in the Parser, that will be checked every time an expression is being parsed, so I decided to put it straight in the cache
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
lgalfaso
added a commit
to lgalfaso/angular.js
that referenced
this pull request
Jan 4, 2015
Mark empty expressions as `constant` and `literal` Closes #angular#7762
|
closing in favor of #10592 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response of #1405 (comment)
I decided to mark it as a literal because
$parse('undefined')is a literal.